[AllPublicDeclarationsHaveDocumentation] Fix behavior for override methods.
#655
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…methods. This was mistakenly broken during a refactor and we didn't have test coverage for it. We didn't have test coverage for it because the tests behave differently than the rule does when executed in the whole pipeline, so we need to fix that too. I'm going to do that in a separate PR, because it might have knock-on effects elsewhere. Fixes swiftlang#651.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was mistakenly broken during a refactor and we didn't have test coverage for it. We didn't have test coverage for it because the tests behave differently than the rule does when executed in the whole pipeline, so we need to fix that too. I'm going to do that in a separate PR, because it might have knock-on effects elsewhere.
Fixes #651.