Install the SwiftPM/Swift Build resources in /usr/share/pm #418
+465
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compnerd
requested changes
May 6, 2025
There was a problem hiding this comment.
I'd rather that we explicitly list the files if possible. Do you expect the list to constantly change dramatically? The only place that we currently harvest is in the clang resources, which has continued to be a source of installation failures. I think that we should prefer to just enumerate the content that we are distributing.
|
I don't expect the list to change dramatically, but it is added to fairly often, and it's unfortunate if we have to stage cross-repo changes every time that happens |
7db0a42 to
4b174e0
Compare
|
I updated this patch to explicitly list everything and am autogenerating the content via scripts in the Swift Build repo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #417 - only the second commit is new
Ensure the Windows installer includes the resources bundled in swiftlang/swift-build#488