Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add missing .npmignore, bump version to 0.7.2 #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 28, 2020
Merged

Conversation

MaxDesiatov
Copy link
Contributor

In 0.7.1 the runtime files are still not available through npm. The reason was this:

If there is a .gitignore file, and .npmignore is missing, .gitignore’s contents will be used instead.

The Runtime directory had .gitignore that mentioned the lib subdirectory with transpiled files. This made sense, but absence of .npmignore excluded these files from uploading.

@MaxDesiatov MaxDesiatov added the bug Something isn't working label Sep 28, 2020
@MaxDesiatov MaxDesiatov requested review from a team, j-f1 and kateinoigakukun and removed request for a team September 28, 2020 09:32
@github-actions
Copy link

Time Change: +238ms (1%)

Total Time: 13,734.25ms

ℹ️ View Unchanged
Test name Duration Change
Serialization/Write JavaScript number directly 174.75ms +4.25ms (2%)
Serialization/Write JavaScript string directly 176.75ms +1.25ms (0%)
Serialization/Swift Int to JavaScript 5,026ms +150ms (2%)
Serialization/Swift String to JavaScript 5,260.75ms +234ms (4%)
Object heap/Increment and decrement RC 3,096ms -151.5ms (4%)

performance-action

@j-f1 j-f1 merged commit 6e84a70 into main Sep 28, 2020
@j-f1 j-f1 deleted the missing-npmignore branch September 28, 2020 15:02
@j-f1
Copy link
Member

j-f1 commented Sep 28, 2020

The files are now present! https://unpkg.com/browse/[email protected]/Runtime/lib/

@MaxDesiatov
Copy link
Contributor Author

Awesome, thanks for tagging the release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants