check maxshape in require_dataset. closes h5py#2018

Helveg · Helveg · commit b7dbde88526a · 2022-06-26T18:47:06.000+02:00
diff --git a/h5py/_hl/group.py b/h5py/_hl/group.py
@@ -228,8 +228,11 @@ def require_dataset(self, name, shape, dtype, exact=False, **kwds):
             if not isinstance(dset, dataset.Dataset):
                 raise TypeError("Incompatible object (%s) already exists" % dset.__class__.__name__)
 
-            if not shape == dset.shape:
-                raise TypeError("Shapes do not match (existing %s vs new %s)" % (dset.shape, shape))
+            if shape != dset.shape:
+                if "maxshape" not in kwds:
+                    raise TypeError("Shapes do not match (existing %s vs new %s)" % (dset.shape, shape))
+                elif kwds["maxshape"] != dset.maxshape:
+                    raise TypeError("Max shapes do not match (existing %s vs new %s)" % (dset.maxshape, kwds["maxshape"]))
 
             if exact:
                 if not dtype == dset.dtype:
