Support pickling of Basic objects #377
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should be ready for a review. Failing test is a network issue. |
|
This is super useful! |
rikardn
approved these changes
Nov 29, 2021
6 tasks
|
In pycalphad, we used to subclass sympy Self-contained example: import pickle
from symengine import Add, Symbol
class StateVariable(Symbol):
def __init__(self, name):
super().__init__(name.upper())
def __reduce__(self):
return self.__class__, (self.name,)
T = StateVariable('T')
loaded_T = pickle.loads(pickle.dumps(T))
assert isinstance(loaded_T, StateVariable), f"Got type {type(loaded_T)}" # passes
loaded_Add_T = list(pickle.loads(pickle.dumps(Add(T, 1))).free_symbols)[0]
assert isinstance(loaded_Add_T, StateVariable), f"Got type {type(loaded_Add_T)}" # failsAssertionError Traceback (most recent call last)
<ipython-input-1-ff0882030409> in <module>
15
16 loaded_Add_T = list(pickle.loads(pickle.dumps(Add(T, 1))).free_symbols)[0]
---> 17 assert isinstance(loaded_Add_T, StateVariable), f"Got type {type(loaded_Add_T)}" # fails
AssertionError: Got type <class 'symengine.lib.symengine_wrapper.Symbol'>Are there any changes here or in our code that we can make to have our subclasses survive a round trip through |
|
Thank you, @isuruf! The changes here and upstream in SymEngine work well and solve our problem. |
This was referenced Dec 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.