Fix build to avoid duplicate files in wheel #402
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the build system to package pure Python files
via distutils/setuptools, and limit CMake to installing the compiled
extension.
The prior logic has installed some of the .py files both via setuptools
and via CMake, to different build directories. As a result,
the resulting wheel contained duplicate files, e.g.:
2170 05-02-2022 07:08 symengine/__init__.py
2170 05-02-2022 07:08 symengine-0.9.2.data/purelib/symengine/__init__.py
Duplicate files cause the wheel to be rejected by the installer package.
After the change, a correct wheel is generated. Installation works
both via PEP517/wheel and via legacy `setup.py install`.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the build system to package pure Python files
via distutils/setuptools, and limit CMake to installing the compiled
extension.
The prior logic has installed some of the .py files both via setuptools
and via CMake, to different build directories. As a result,
the resulting wheel contained duplicate files, e.g.:
Duplicate files cause the wheel to be rejected by the installer package.
After the change, a correct wheel is generated. Installation works
both via PEP517/wheel and via legacy
setup.py install.