Add a lambdify func. that throws ModuleNotFoundError when numpy missing #432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isuruf
reviewed
Feb 14, 2023
symengine/__init__.py
Outdated
Comment on lines
59
to
60
| def lambdify(args, exprs, **kwargs): | ||
| raise ModuleNotFoundError("Cannot import numpy, which is required for `lambdify` to work") |
There was a problem hiding this comment.
Use a __getattr__ method here and raise an AttributeError with this error message?
There was a problem hiding this comment.
Oh, didn't know you could. Today I learned.. since 3.7 apparently.
isuruf
reviewed
Feb 14, 2023
|
Merging without appveyor for now as the queue is long. Will revert if appveyor fails. Thanks @bjodah |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
numpyis an optional dependency. Which is confusing since we don't definelambdify,LambdifyandLambdifyCSEwhen it's missing.This PR aims to reduce the surprise/confusion when that situation arises.
cf. sympy/sympy#24673 (comment)