-
-
Notifications
You must be signed in to change notification settings - Fork 264
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: symfony/console
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 72d080e
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: symfony/console
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: f793dd5
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 10 commits
- 6 files changed
- 4 contributors
Commits on Sep 20, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 97f0e2d - Browse repository at this point
Copy the full SHA 97f0e2dView commit details
Commits on Sep 25, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 807379c - Browse repository at this point
Copy the full SHA 807379cView commit details -
* 5.4: Tweak error/exception handler registration
Configuration menu - View commit details
-
Copy full SHA for 12b2c77 - Browse repository at this point
Copy the full SHA 12b2c77View commit details -
Configuration menu - View commit details
-
Copy full SHA for 31ed653 - Browse repository at this point
Copy the full SHA 31ed653View commit details -
minor #58355 Add PR template and auto-close PR on subtree split repos…
…itories (GromNaN) This PR was squashed before being merged into the 5.4 branch. Discussion ---------- Add PR template and auto-close PR on subtree split repositories | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | Fix #57267 | License | MIT Extract the Pull Request Template from #54653. ~The GitHub action did not work as said by `@nicolas`-grekas symfony/symfony#57267 (comment) Replaced by https://github.com/superbrothers/close-pull-request. Commits ------- d90fa7ab08f Add PR template and auto-close PR on subtree split repositories
Configuration menu - View commit details
-
Copy full SHA for 0deed11 - Browse repository at this point
Copy the full SHA 0deed11View commit details -
* 5.4: Add PR template and auto-close PR on subtree split repositories
Configuration menu - View commit details
-
Copy full SHA for 97987da - Browse repository at this point
Copy the full SHA 97987daView commit details
Commits on Sep 28, 2024
-
bug #58332 [Console] Suppress
proc_open
errors within `Terminal::re……adFromProcess` (fritzmg) This PR was merged into the 5.4 branch. Discussion ---------- [Console] Suppress `proc_open` errors within `Terminal::readFromProcess` | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | | License | MIT When instantiating `SymfonyStyle` in a command it will try to determine the maximum width of the current console interface. https://github.com/symfony/symfony/blob/6687e4ea35f45ebd73fb0315938103628cfb13a0/src/Symfony/Component/Console/Style/SymfonyStyle.php#L53 This will execute `stty -a | grep columns` down the line. Access to `stty` might be disallowed however, resulting in the following error: ``` ErrorException: Warning: proc_open(): Exec failed: Permission denied #16 /vendor/symfony/console/Terminal.php(220): Symfony\Component\Console\Terminal::readFromProcess #15 /vendor/symfony/console/Terminal.php(204): Symfony\Component\Console\Terminal::getSttyColumns #14 /vendor/symfony/console/Terminal.php(170): Symfony\Component\Console\Terminal::initDimensionsUsingStty #13 /vendor/symfony/console/Terminal.php(153): Symfony\Component\Console\Terminal::initDimensions #12 /vendor/symfony/console/Terminal.php(94): Symfony\Component\Console\Terminal::getWidth #11 /vendor/symfony/console/Style/SymfonyStyle.php(55): Symfony\Component\Console\Style\SymfonyStyle::__construct #10 /vendor/symfony/messenger/Command/ConsumeMessagesCommand.php(136): Symfony\Component\Messenger\Command\ConsumeMessagesCommand::interact #9 /vendor/symfony/console/Command/Command.php(311): Symfony\Component\Console\Command\Command::run ``` (Stack Trace actually from Symfony 6) The phpDoc of `Terminal::getSttyColumns` states > Runs and parses stty -a if it's available, _suppressing any error output_. The latter might refer to `['suppress_errors' => true]` (though I am not sure) - which is a Windows only functionality. In any case, since `Terminal::readFromProcess` already checks for ```php if (!$process = proc_open(…)) { return null; } ``` and ```php if (!\is_resource($process)) { return null; } ``` upstream in Symfony 6/7, indicating that `proc_open` might fail - this error can additionally be suppressed using `@`. Besides, `Process::start` also uses ``@proc_open`` (added in symfony/symfony@099481f "Prevent warning in proc_open()"). Commits ------- 575249a3431 suppress proc_open errors
Configuration menu - View commit details
-
Copy full SHA for ea89256 - Browse repository at this point
Copy the full SHA ea89256View commit details -
* 5.4: Add missing Albanian translations for Security and Validator components suppress proc_open errors [DependencyInjection] Fix `XmlFileLoader` not respecting when env for services
Configuration menu - View commit details
-
Copy full SHA for 7f74336 - Browse repository at this point
Copy the full SHA 7f74336View commit details
Commits on Oct 8, 2024
-
minor #58472 CS: clean some whitespaces/indentation (keradus)
This PR was squashed before being merged into the 7.2 branch. Discussion ---------- CS: clean some whitespaces/indentation | Q | A | ------------- | --- | Branch? | 7.2 | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Issues | Fix CS | License | MIT Commits ------- d0f63b8afa1 CS: clean some whitespaces/indentation
Configuration menu - View commit details
-
Copy full SHA for 108d436 - Browse repository at this point
Copy the full SHA 108d436View commit details
Commits on Oct 9, 2024
-
* 5.4: minor #58472 CS: clean some whitespaces/indentation (keradus) Fix newline harden test to not depend on the system's configured default timezone [Form] Support intl.use_exceptions/error_level in NumberToLocalizedStringTransformer [ExpressionLanguage] Add missing test case for `Lexer` [FrameworkBundle] Fix passing request_stack to session.listener ensure session storages are opened in tests before destroying them [HttpKernel] Correctly merge `max-age`/`s-maxage` and `Expires` headers [Security][Validator] Check translations for Czech [Security] Fix serialized object representation in tests [DoctrineBridge] Fix risky test warnings
Configuration menu - View commit details
-
Copy full SHA for f793dd5 - Browse repository at this point
Copy the full SHA f793dd5View commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 72d080e...f793dd5