For AND operator, the left operand should have parentheses, not only right #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@achasseux Sorry for being very late but this repository is read-only, so it's not really monitored by anyone. Could you open a pull request on symfony/symfony instead? Thanks you. |
|
Moved to symfony/symfony#26010 |
nicolas-grekas
added a commit
to symfony/symfony
that referenced
this pull request
Feb 3, 2018
…ve parentheses, not only right operand (Arnaud CHASSEUX) This PR was merged into the 2.7 branch. Discussion ---------- [CssSelector] For AND operator, the left operand should have parentheses, not only right operand | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - From symfony/css-selector#3 Commits ------- 76b40dc [CssSelector] For AND operator, the left operand should have parentheses, not only right operand
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
When CSS selector is translated into XPath, the following
becomes :
It should become :
This pull request adds the left-operand parentheses.