Optimized slugger: trimming dash at the beginning & end and removed doubles dashes #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sebastianblum thanks for creating this PR. I love it when improvements are short and simple! Just a note for future improvements: in this particular application we don't care about the actual slugger logic. We just use it as an example of how to define a service for classes that implement a simple feature. However, since your PR doesn't complicate anything and it includes a much needed improvement, it makes a lot of sense to merge it. Thanks. |
javiereguiluz
added a commit
that referenced
this pull request
Mar 28, 2015
…nd removed doubles dashes (Sebastian Blum) This PR was merged into the master branch. Discussion ---------- Optimized slugger: trimming dash at the beginning & end and removed doubles dashes Hello, I found the symfony-demo repository and the idea behind is great. also in the symfony best practices, the slugger has 2 problems in my opinion. * several dashes like lorem--ipsum * dashes at the begin or end like -lorem-ipsum- here is my litte pull request. sebastian Commits ------- 5c82409 Optimized slugger: trimming dash at the beginning & end and removed double dashes
sayjun0505
added a commit
to sayjun0505/sym_proj
that referenced
this pull request
Apr 16, 2023
This PR was merged into the master branch. Discussion ---------- Remove redundant function call After symfony/demo#15, the inner `trim()` call is no longer required as the outer one already trims all dashes. Commits ------- 22ee7c5 Remove redundant function call
spider-yamet
added a commit
to spider-yamet/sym_proj
that referenced
this pull request
Apr 16, 2023
This PR was merged into the master branch. Discussion ---------- Remove redundant function call After symfony/demo#15, the inner `trim()` call is no longer required as the outer one already trims all dashes. Commits ------- 22ee7c5 Remove redundant function call
frederickboyd
pushed a commit
to frederickboyd/frederickboyd
that referenced
this pull request
May 25, 2025
This PR was merged into the master branch. Discussion ---------- Remove redundant function call After symfony/demo#15, the inner `trim()` call is no longer required as the outer one already trims all dashes. Commits ------- 22ee7c5 Remove redundant function call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I found the symfony-demo repository and the idea behind is great.
also in the symfony best practices, the slugger has 2 problems in my opinion.
here is my litte pull request.
sebastian