Move the twbs/bootstrap dependency from require-dev to require #1540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
BTW to make the demo work in production mode I also had to run:
|
|
Jan, sorry I forgot about this PR. Merged! About the asset error, in the past (when we used Webpack Encore) we included the compiled web assets in this repository. Maybe we should do the same now with AssetMapper? This app has to work perfectly without running any command or configuring anything. Let's think a bit about this. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know if the demo is intended to work in production mode. However since the assets are no longer bundled, but generated during
composer installwithsass:buildi think it makes sense to ensure that bootstrap is always available by moving it to the required dependencies.Fixes #1509