Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update RedirectToPreferredLocaleSubscriber.php #1569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

flovntp
Copy link
Contributor

@flovntp flovntp commented May 13, 2025

It needs to be an array for this eventListener to be triggered
(just get the case where this eventListener is not triggered because of that)

It needs to be an array for this eventListener to be triggered
@94noni
Copy link
Contributor

94noni commented May 15, 2025

are you sure its not because of another event prior to this one that redirects or stoped the flow?
because its legit to have event => method as well as what you propose as far as I know

@stof
Copy link
Member

stof commented May 15, 2025

To me, the description of the change is what causes confusion in the discussion. The actual change being done here is changing the priority of the listener. Saying "it must be an array" does not describe what is done (indeed, to use a non-0 priority, it needs to be an array, but you could make it an array without changing the priority, so using an array is not the meaningful change).

and then, what needs to be explained is why the priority needs to be so high.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants