Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Use Symfony console style #566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Use Symfony console style #566

wants to merge 3 commits into from

Conversation

elkuku
Copy link
Contributor

@elkuku elkuku commented May 27, 2017 •
edited
Loading

Ref.: #472

This will use the SymfonyStyle style for console commands.

Unfortunately the advanced features used are no supported so we can't really live without the "low level" helpers...

  • Question max attempts
  • Table using BufferedOutput to "capture" the table

I have removed the "max attempts" feature from the delete-user command and was also tempted to remove this behavior in the add-user command on the fields that doesn't do much validation (user name and full name) - WDYT?

@javiereguiluz
Copy link
Member

@elkuku thanks for this contribution! I've merged this 515c00e and I'll create a new PR to propose some minor changes to this. Thanks!

@javiereguiluz javiereguiluz mentioned this pull request Jun 19, 2017
Closed
javiereguiluz added a commit that referenced this pull request Jun 20, 2017
@javiereguiluz
minor #595 Tweaked the use of SymfonyStyle in commands (javiereguiluz)
c63ad95 
This PR was squashed before being merged into the master branch (closes #595).

Discussion
----------

Tweaked the use of SymfonyStyle in commands

This is a continuation of #566.

Commits
-------

5180bdc Tweaked the use of SymfonyStyle in commands
@javiereguiluz javiereguiluz mentioned this pull request Jun 20, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@20uf 20uf 20uf approved these changes

Assignees
No one assigned
Labels
FINISHED
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elkuku @javiereguiluz @20uf