Update ORMQueryBuilderLoader.php #4
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Type::GUID can be used as entity ID and is Connection::PARAM_STR_ARRAY when submitting form with required set to FALSE and empty entity with Type::GUID as entity ID, we still receive an SQLSTATE[22P02]: Invalid text representation: 7 ERROR: invalid input syntax for uuid: "" in the PostgreSQL Platform for example. symfony/symfony#14465 ???
|
@sasedev it is read-only repository. You should add tests to your fix and create new PR in https://github.com/symfony/symfony |
|
Thanks for this PR. Yet I invite you to submit it on the main symfony/symfony repository: this is where merges happen. Note that you should add test cases while doing so. Cheers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type::GUID can be used as entity ID and is Connection::PARAM_STR_ARRAY
when submitting form with required set to FALSE and empty entity with Type::GUID as entity ID,
we still receive an SQLSTATE[22P02]: Invalid text representation: 7 ERROR: invalid input syntax for uuid: ""
in the PostgreSQL Platform for example.
symfony/symfony#14465 ???