Skip updating phpunit.xml files when .env.test exists #434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Replaces #423 |
dunglas
approved these changes
Nov 9, 2018
|
Just tested with all recent changes all together: it's deceptively simple. It feels like "it just works" :) |
maxhelias
approved these changes
Nov 10, 2018
This was referenced Nov 11, 2018
symfony-splitter
pushed a commit
to symfony/dotenv
that referenced
this pull request
Nov 12, 2018
…nd (nicolas-grekas) This PR was merged into the 4.2-dev branch. Discussion ---------- [Dotenv] load .env.dist when it exists and .env is not found | Q | A | ------------- | --- | Branch? | 4.2 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #29170 | License | MIT | Doc PR | - As illustrated in #29170, it can be useful to opt out from the `.env` convention and fall back to defining env vars in `.env.dist` instead. This PR allows that by loading `.env.dist` when it exists and `.env` is not found. Needs symfony/flex#434 to work seamlessly when using Flex. Commits ------- 841185bb9f [Dotenv] load .env.dist when it exists and .env is not found
nicolas-grekas
added a commit
to symfony/symfony
that referenced
this pull request
Nov 12, 2018
…nd (nicolas-grekas) This PR was merged into the 4.2-dev branch. Discussion ---------- [Dotenv] load .env.dist when it exists and .env is not found | Q | A | ------------- | --- | Branch? | 4.2 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #29170 | License | MIT | Doc PR | - As illustrated in #29170, it can be useful to opt out from the `.env` convention and fall back to defining env vars in `.env.dist` instead. This PR allows that by loading `.env.dist` when it exists and `.env` is not found. Needs symfony/flex#434 to work seamlessly when using Flex. Commits ------- 841185b [Dotenv] load .env.dist when it exists and .env is not found
fabpot
approved these changes
Nov 12, 2018
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Nov 12, 2018
…icolas-grekas) This PR was merged into the 1.1-dev branch. Discussion ---------- Skip updating phpunit.xml files when .env.test exists This is to support `.env` < `.env.local` < `.env.test` < `.env.test.local` dotenv files *withouth affecting existing workflows* based on `.env(.dist)` and `phpunit.xml(.dist)`. Leveraged by symfony/recipes#481 Best reviewed [ignoring whitespaces](https://github.com/symfony/flex/pull/434/files?w=1). Commits ------- ae7128a Skip updating phpunit.xml files when .env.test exists
tgalopin
pushed a commit
to tgalopin/flex
that referenced
this pull request
Dec 3, 2020
markovlatkovic
pushed a commit
to markovlatkovic/recipes
that referenced
this pull request
May 24, 2024
markovlatkovic
pushed a commit
to markovlatkovic/recipes
that referenced
this pull request
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to support
.env<.env.local<.env.test<.env.test.localdotenv files withouth affecting existing workflows based on.env(.dist)andphpunit.xml(.dist).Leveraged by symfony/recipes#481
Best reviewed ignoring whitespaces.