Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[make:*] fix bundled php-cs-fixer not working on windows #1435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 3, 2024
Merged

[make:*] fix bundled php-cs-fixer not working on windows #1435

merged 1 commit into from
Feb 3, 2024

Conversation

jrushlow
Copy link
Collaborator

@jrushlow jrushlow commented Feb 3, 2024 •
edited
Loading

  • adds conditional to properly set PHP_CS_FIXER_IGNORE_ENV in windows environments. Before the was being done incorrectly using bash semantics.

@jrushlow jrushlow added the Bug Bug Fix label Feb 3, 2024
@jrushlow jrushlow force-pushed the bug/php-cs-fixer-windows branch from c2111b1 to 2a2f0bc Compare February 3, 2024 08:19
@jrushlow jrushlow merged commit fc8038d into symfony:main Feb 3, 2024
@jrushlow jrushlow deleted the bug/php-cs-fixer-windows branch February 3, 2024 08:20
@jrushlow jrushlow mentioned this pull request Feb 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug Bug Fix Related Tests Pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jrushlow