Deprecate Argon2i encoder used in make:user #398
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pluseg
reviewed
May 25, 2019
There was a problem hiding this comment.
Need to update four tests — https://travis-ci.org/symfony/maker-bundle/jobs/535332472.
|
@pluseg if you're interested, I'm sure Nicolas would love you if you grabbed his commit, updated the tests, and finished the PR :) |
|
Thank you Nicolas! |
weaverryan
added a commit
that referenced
this pull request
Jun 14, 2019
…kas, weaverryan) This PR was merged into the 1.0-dev branch. Discussion ---------- Deprecate Argon2i encoder used in make:user `auto` is the only future-proof option, no need to allow ppl to choose. Fixes #386 Commits ------- 89e7f59 updating security tests for bcrypt vs auto setting dee904b Deprecate Argon2i encoder used in make:user
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
autois the only future-proof option, no need to allow ppl to choose.Fixes #386