Enhancement: Use GithubActions for tests instead of Travis + PHP 8.0 tests #701
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e4023b6 to
2095c70
Compare
jderusse
reviewed
Oct 26, 2020
5 tasks
wouterj
reviewed
Oct 26, 2020
de5c709 to
8556b56
Compare
33d8200 to
831ae50
Compare
831ae50 to
1ad263a
Compare
OskarStark
commented
Oct 26, 2020
d8f6c08 to
132a55c
Compare
Nyholm
reviewed
Oct 27, 2020
There was a problem hiding this comment.
Looking at the build failure:
"Creating a "symfony/skeleton:dev-main" project at "./flex_projectdev-main"
[InvalidArgumentException]
Could not find package symfony/skeleton with version dev-main.
It seams that the MakerTestEnvironment::$targetFlexVersion is used for the skeleton too.. Is that right?
OskarStark
commented
Oct 27, 2020
8e1e1db to
6426016
Compare
|
Ok |
weaverryan
reviewed
Oct 27, 2020
weaverryan
reviewed
Oct 27, 2020
9f7a906 to
08f6ede
Compare
weaverryan
reviewed
Oct 27, 2020
OskarStark
commented
Oct 27, 2020
18b1812 to
17fbba0
Compare
This was referenced Oct 27, 2020
weaverryan
added a commit
that referenced
this pull request
Oct 27, 2020
weaverryan
added a commit
that referenced
this pull request
Oct 27, 2020
6668b4c to
3e45731
Compare
3e45731 to
7742a57
Compare
So that unreleased packages can be used
|
Thank you Oskar for your great work on this! php8 is still failing, but it will be for awhile until related packages add php 8 support. Not much we can do there |
javiereguiluz
added a commit
to EasyCorp/EasyAdminBundle
that referenced
this pull request
Oct 28, 2020
This PR was squashed before being merged into the 3.0.x-dev branch. Discussion ---------- Move from Travis CI to GitHub Actions This PR is ~inspired by~ copied from the great PR made by @OskarStark in the MakerBundle (symfony/maker-bundle#701). Let's see if we can move to GitHub Actions easily. Commits ------- 569234b Move from Travis CI to GitHub Actions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.