Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[make:crud] use POST method instead of DELETE #825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 2, 2021
Merged

[make:crud] use POST method instead of DELETE #825

merged 1 commit into from
Mar 2, 2021

Conversation

jrushlow
Copy link
Collaborator

@jrushlow jrushlow commented Feb 24, 2021 •
edited
Loading

Starting in Symfony 5.3, framework.http_method_override defaults to false. This prevents CRUD form submission for PUT, PATCH &/or DELETE methods. See symfony/recipes#892

This PR conditionally sets http_method_override to true when using make:crud if using Symfony 5.3+

We stop using the DELETE method override in favor of using POST on the delete operation.

@jrushlow jrushlow mentioned this pull request Feb 24, 2021
Merged
weaverryan
weaverryan reviewed Feb 24, 2021
View reviewed changes
@jrushlow jrushlow force-pushed the fix/http-method-override branch from ae7fa3e to 637014e Compare February 25, 2021 14:53
@jrushlow jrushlow changed the title [make:crud] enable http_method_override in 5.3 [make:crud] use POST method instead of DELETE Feb 25, 2021
@jrushlow jrushlow force-pushed the fix/http-method-override branch from e4e824e to fc9cd2a Compare March 2, 2021 08:00
@weaverryan
Copy link
Member

Thanks Jesse!

@weaverryan weaverryan merged commit 827e153 into symfony:main Mar 2, 2021
@jrushlow jrushlow deleted the fix/http-method-override branch March 2, 2021 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weaverryan weaverryan weaverryan left review comments

Assignees
No one assigned
Labels
Related Tests Pass Status: Needs Review Needs to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jrushlow @weaverryan