Remove FixEmptyLoggerPass
#545
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
approved these changes
Oct 3, 2025
GromNaN
added a commit
that referenced
this pull request
Oct 6, 2025
This PR was merged into the 4.x branch. Discussion ---------- Removed legacy getter from `LoggerChannelPass` | Q | A | ------------- | --- | Branch? | 4.x | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | - | License | MIT Follow-up to #545 The `LoggerChannelPass::getChannels()` method was originally added in 4d5a969 for the `DebugHandlerPass` and was later used in the `FixEmptyLoggerPass`. Since both passes have been removed, this method is no longer needed. Commits ------- 833daad Removed legacy getter from `LoggerChannelPass`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
FixEmptyLoggerPassclass was added in c3fbde4 to fix an issue with monolog 1.x that has been fixed in 2.x by Seldaek/monolog@ad37b7b. It can be removed since monolog 3.x is required.