This repository was archived by the owner on Nov 9, 2017. It is now read-only.
Fix ModelType.php for Symfony-2.8 #1
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using null will raise following exception: Catchable Fatal Error: Argument 1 passed to Symfony\Component\Form\Extension\Core\Type\ChoiceType::normalizeLegacyChoices() must be of the type array, null given, called in .../vendor/symfony/symfony/src/Symfony/Component/Form/Extension/Core/Type/ChoiceType.php on line 266 and defined
As a consequence of fix fafca72, $choices is not loaded. With this test, it is.
|
I guess the simplest way would be to do similar thing as in EntityType for doctrine - to make choices_as_values default 'true' according to a comment in symfony/symfony#16796 |
| @@ -105,7 +105,7 @@ public function __construct($class, $labelPath = null, $choices = null, $queryOb | |||
| $this->identifier = $this->query->getTableMap()->getPrimaryKeys(); | |||
| } | |||
|
|
|||
| $this->loaded = is_array($choices) || $choices instanceof \Traversable; | |||
| $this->loaded = (is_array($choices) && array() !== $choices) || $choices instanceof \Traversable; | |||
There was a problem hiding this comment.
this is wrong. If the user passes an empty array explicitly, it must be used as the loaded choices
|
I think this has been solved by the choice list normalizer and can be closed. See symfony/symfony/pull/17163 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using null will raise following exception: Catchable Fatal Error: Argument 1 passed to Symfony\Component\Form\Extension\Core\Type\ChoiceType::normalizeLegacyChoices() must be of the type array, null given, called in .../vendor/symfony/symfony/src/Symfony/Component/Form/Extension/Core/Type/ChoiceType.php on line 266 and defined