Fixes #9 Bridge error when no file is selected #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $temporaryPath = $this->getTemporaryPath(); | ||
| $psrUploadedFile->moveTo($temporaryPath); | ||
| $temporaryPath = ''; | ||
| $clientFileName = null; |
There was a problem hiding this comment.
you could set this to ''. below there is a check against null which only needs to trigger if $psrUploadedFile->getClientFilename() returns null.
|
Please squash commits per author (1 commit per author). |
Fixed PHP 5.3.3 array syntax
8f83138 to
e5d62e6
Compare
| $file = new UploadedFile('', '', null, 0, UPLOAD_ERR_NO_FILE, true); | ||
| $this->assertEquals(0, $file->getSize()); | ||
| $this->assertEquals(UPLOAD_ERR_NO_FILE, $file->getError()); | ||
| $this->assertFalse($file->getSize()); |
There was a problem hiding this comment.
There should be a third argument like this:
$this->assertFalse($file->getSize(), 'SplFile::getSize() returns false on error');There was a problem hiding this comment.
Don't you mean a second argument to assertFalse? It would be a third argument for assertEquals, but the comment you linked to erroneously mentioned assertFalse.
Assert false doesn't take a third argument.
|
It looks like all the comments from #10 have been addressed here. Does anyone else have any issues, or can we merge this? |
|
Thank you @Danielss89. |
fabpot
added a commit
that referenced
this pull request
Aug 18, 2016
…ielss89) This PR was merged into the master branch. Discussion ---------- Fixes #9 Bridge error when no file is selected Q A Bug fix? yes New feature? no BC breaks? no Deprecations? no Tests pass? yes Fixed tickets #9 License MIT Doc PR Commits ------- a1a631a Update assert error message e5d62e6 Fixes based on code-review 101b608 Handles null file in createrequest bridge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #9
License MIT
Doc PR