[web-profiler-bundle] Enable serializer data collector on 6.1 #1095
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbae04b to
68519e7
Compare
68519e7 to
751ea55
Compare
751ea55 to
1f3abed
Compare
|
Thanks for the PR 😍 How to test these changes in your application
Diff between recipe versionsIn order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes. symfony/web-profiler-bundle3.3 vs 5.3diff --git a/symfony/web-profiler-bundle/3.3/config/packages/dev/web_profiler.yaml b/symfony/web-profiler-bundle/3.3/config/packages/dev/web_profiler.yaml
deleted file mode 100644
index e92166a..0000000
--- a/symfony/web-profiler-bundle/3.3/config/packages/dev/web_profiler.yaml
+++ /dev/null
@@ -1,6 +0,0 @@
-web_profiler:
- toolbar: true
- intercept_redirects: false
-
-framework:
- profiler: { only_exceptions: false }
diff --git a/symfony/web-profiler-bundle/3.3/config/packages/test/web_profiler.yaml b/symfony/web-profiler-bundle/3.3/config/packages/test/web_profiler.yaml
deleted file mode 100644
index 03752de..0000000
--- a/symfony/web-profiler-bundle/3.3/config/packages/test/web_profiler.yaml
+++ /dev/null
@@ -1,6 +0,0 @@
-web_profiler:
- toolbar: false
- intercept_redirects: false
-
-framework:
- profiler: { collect: false }
diff --git a/symfony/web-profiler-bundle/5.3/config/packages/web_profiler.yaml b/symfony/web-profiler-bundle/5.3/config/packages/web_profiler.yaml
new file mode 100644
index 0000000..17893da
--- /dev/null
+++ b/symfony/web-profiler-bundle/5.3/config/packages/web_profiler.yaml
@@ -0,0 +1,15 @@
+when@dev:
+ web_profiler:
+ toolbar: true
+ intercept_redirects: false
+
+ framework:
+ profiler: { only_exceptions: false }
+
+when@test:
+ web_profiler:
+ toolbar: false
+ intercept_redirects: false
+
+ framework:
+ profiler: { collect: false }
diff --git a/symfony/web-profiler-bundle/3.3/config/routes/dev/web_profiler.yaml b/symfony/web-profiler-bundle/3.3/config/routes/dev/web_profiler.yaml
deleted file mode 100644
index c82beff..0000000
--- a/symfony/web-profiler-bundle/3.3/config/routes/dev/web_profiler.yaml
+++ /dev/null
@@ -1,7 +0,0 @@
-web_profiler_wdt:
- resource: '@WebProfilerBundle/Resources/config/routing/wdt.xml'
- prefix: /_wdt
-
-web_profiler_profiler:
- resource: '@WebProfilerBundle/Resources/config/routing/profiler.xml'
- prefix: /_profiler
diff --git a/symfony/web-profiler-bundle/5.3/config/routes/web_profiler.yaml b/symfony/web-profiler-bundle/5.3/config/routes/web_profiler.yaml
new file mode 100644
index 0000000..8d85319
--- /dev/null
+++ b/symfony/web-profiler-bundle/5.3/config/routes/web_profiler.yaml
@@ -0,0 +1,8 @@
+when@dev:
+ web_profiler_wdt:
+ resource: '@WebProfilerBundle/Resources/config/routing/wdt.xml'
+ prefix: /_wdt
+
+ web_profiler_profiler:
+ resource: '@WebProfilerBundle/Resources/config/routing/profiler.xml'
+ prefix: /_profiler
diff --git a/symfony/web-profiler-bundle/3.3/manifest.json b/symfony/web-profiler-bundle/5.3/manifest.json
index cb84a24..be74128 100644
--- a/symfony/web-profiler-bundle/3.3/manifest.json
+++ b/symfony/web-profiler-bundle/5.3/manifest.json
@@ -4,5 +4,8 @@
},
"copy-from-recipe": {
"config/": "%CONFIG_DIR%/"
+ },
+ "conflict": {
+ "symfony/framework-bundle": "<5.3"
}
}5.3 vs 6.1diff --git a/symfony/web-profiler-bundle/5.3/config/packages/web_profiler.yaml b/symfony/web-profiler-bundle/6.1/config/packages/web_profiler.yaml
index 17893da..b946111 100644
--- a/symfony/web-profiler-bundle/5.3/config/packages/web_profiler.yaml
+++ b/symfony/web-profiler-bundle/6.1/config/packages/web_profiler.yaml
@@ -4,7 +4,9 @@ when@dev:
intercept_redirects: false
framework:
- profiler: { only_exceptions: false }
+ profiler:
+ only_exceptions: false
+ collect_serializer_data: true
when@test:
web_profiler:
diff --git a/symfony/web-profiler-bundle/5.3/manifest.json b/symfony/web-profiler-bundle/6.1/manifest.json
index be74128..fceb97f 100644
--- a/symfony/web-profiler-bundle/5.3/manifest.json
+++ b/symfony/web-profiler-bundle/6.1/manifest.json
@@ -6,6 +6,6 @@
"config/": "%CONFIG_DIR%/"
},
"conflict": {
- "symfony/framework-bundle": "<5.3"
+ "symfony/framework-bundle": "<6.1"
}
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See symfony/symfony#46625 for background.