[framework-bundle] Disable the logger in test env #248
Conversation
dunglas
commented
Nov 10, 2017
| Q | A |
|---|---|
| License | MIT |
| @@ -2,3 +2,7 @@ framework: | |||
| test: ~ | |||
| #session: | |||
| # storage_id: session.storage.mock_file | |||
|
|
|||
| services: | |||
| # Disable logs | |||
There was a problem hiding this comment.
As soon as Monolog is used with a proper stream handler for instance, registering this null logger probably isn't a good idea.
There was a problem hiding this comment.
Why? It will speed up the builds, even with Monolog (no IO).
There was a problem hiding this comment.
Logs can be useful to understand why a test fail. I'm not sure about this as is in the recipe.
There was a problem hiding this comment.
Anyway monolog has no specific config for tests right now.
It's just a recipe, for specific needs, debugging etc, the user can (should?) modify this file.
There was a problem hiding this comment.
the question then is whether this logger is winning over monolog or no. This should be checked
The goal is to have it winning over the default logger added in FrameworkBundle when no logger is defined
There was a problem hiding this comment.
or maybe we should make it possible to disable the default logger via config
|
closing in favor of #281 |