[FrameworkBundle][Routing] Add a welcome controller #279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
suggested changes
Nov 25, 2017
ghost
suggested changes
Nov 25, 2017
|
Starting from Symfony 3.4, this behavior is hardcoded in debug mode when there is no route: |
|
As you noticed, we decided to go another route with the PR you referenced. We don't want to generate code that is not useful (when developing an API, you don't need a template directory, we also never recommend using PHP for templates, ...). Moreover, maker-bundle now allows to easily generate controllers and templates, so having a default controller is not really needed anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be easier for newcomers to start with a predefined controller and a working route.
Also, I think we could get rid of this code : symfony/symfony#24403
I hardcoded the template path in the
manifest.jsonbecause Flex doesn't have it in the options : https://github.com/symfony/flex/blob/master/src/Flex.php#L284