Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[symfony/framework-bundle] Secure session defaults with "cookie_secure: auto" and "cookie_samesite: lax" #452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
1 commit merged into from
Sep 4, 2018
Merged

Conversation

nicolas-grekas
Copy link
Member

@nicolas-grekas nicolas-grekas commented Aug 22, 2018

Q A
License MIT

Enabling symfony/symfony#28244 and symfony/symfony#28168 by default.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

@fabpot
Copy link
Member

fabpot commented Aug 28, 2018

That only works on 4.2+, so we probably need a new directory for that version.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

@nicolas-grekas nicolas-grekas changed the title Set "framework.session.cookie_secure" to "auto" by default [symfony/framework-bundle] Secure session defaults with "cookie_secure: auto" and "cookie_samesite: lax" Sep 4, 2018
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

@nicolas-grekas
Copy link
Member Author

That only works on 4.2+, so we probably need a new directory for that version.

Indeed, updated.
Now also enabled "cookie_samesite: lax" by default.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

@ghost ghost merged commit 875018c into symfony:master Sep 4, 2018
ghost pushed a commit that referenced this pull request Sep 4, 2018
@nicolas-grekas nicolas-grekas deleted the session-auto-secure branch September 9, 2018 19:31
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants