Load .env.dist when it exists and .env is not found #488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
commented
Nov 11, 2018
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| <!-- https://phpunit.de/manual/current/en/appendixes.configuration.html --> | |||
| <phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | |||
| xsi:noNamespaceSchemaLocation="http://schema.phpunit.de/4.7/phpunit.xsd" | |||
| xsi:noNamespaceSchemaLocation="http://schema.phpunit.de/6.5/phpunit.xsd" | |||
There was a problem hiding this comment.
version bump related to discussion in symfony/symfony#29174
tl;dr: only the very latest version of phpunit validates these, so bumping doesn't do anything for older versions, and the latest version needs recent xsd to pass validation.
xabbuh
approved these changes
Nov 11, 2018
maxhelias
approved these changes
Nov 11, 2018
dunglas
approved these changes
Nov 12, 2018
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Matches symfony/symfony#29171