Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add recipe for http-client #548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add recipe for http-client #548

wants to merge 1 commit into from

Conversation

nicolas-grekas
Copy link
Member

Q A
License MIT

Needs symfony/symfony#30419

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

@ghost ghost requested a deployment to staging March 12, 2019 15:34 Abandoned
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

@@ -0,0 +1,4 @@
framework:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In other recipes we only create config files if the bring additional value and don't only expose default variables and this looks only like the defaults 🤔

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the http_client service needs to be explicitly enabled, this does it
but maybe we should enable it conditionally in the fwb integration!
Is that what your mean? Doing a class_exists check there and remove the recipe?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the HttpClient package is not required by any of the skeleton's dependencies, it means it certainly can be activated automatically by the fwb if the package is installed, this would probably save a recipe for it 😄

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I thought about it. Does it makes sense?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just added a comment on the PR that we should auto-activate it if the component is installed.

@nicolas-grekas nicolas-grekas deleted the http-client branch March 25, 2019 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants