Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[MonologBundle] Added (commented) configuration for log format #552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
1 commit merged into from
Sep 9, 2019
Merged

[MonologBundle] Added (commented) configuration for log format #552

1 commit merged into from
Sep 9, 2019

Conversation

lyrixx
Copy link
Member

@lyrixx lyrixx commented Mar 12, 2019

Q A
License MIT

ghost
ghost approved these changes Mar 12, 2019
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

@lyrixx lyrixx mentioned this pull request Mar 12, 2019
Merged
ghost
ghost approved these changes Mar 12, 2019
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

@Pierstoval Pierstoval mentioned this pull request Mar 12, 2019
Closed
@Nyholm
Copy link
Member

Nyholm commented Apr 6, 2019

I would much rather have a link to the documentation that showing comments like this in the recipes.

fabpot
fabpot approved these changes Jun 19, 2019
View reviewed changes
Copy link
Member

@fabpot fabpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the doc team says it won't document this, I think it's fair to add this comment.

@lyrixx
Copy link
Member Author

lyrixx commented Sep 9, 2019

@Nyholm Let's merge it?

Nyholm
Nyholm approved these changes Sep 9, 2019
View reviewed changes
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you!

ghost pushed a commit that referenced this pull request Sep 9, 2019
Merge pull request #552
f9c6da3
@ghost ghost merged commit 764f68c into symfony:master Sep 9, 2019
@lyrixx lyrixx deleted the sf-log-cli branch September 9, 2019 15:36
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierstoval Pierstoval Pierstoval left review comments

@fabpot fabpot fabpot approved these changes

@Nyholm Nyholm Nyholm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lyrixx @Nyholm @fabpot @Pierstoval