-
-
Notifications
You must be signed in to change notification settings - Fork 495
Tweak configuration for app.yaml #65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
resource: '../../src/*' | ||
# you can exclude directories or files | ||
# but if a service is unused, it's removed anyway | ||
exclude: '../../src/{Entity,Repository}' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about excluding Controller
too (see symfony/symfony-standard#1070 (comment))?
Just to make things consciously: this will load+track all classes in src/ to build the container. |
@nicolas-grekas That's indeed a good point and why we add a list of specific directories before. We made the same change in Symfony SE, so we need to decide between DX and performance here. /cc @weaverryan |
I don't think that's a big deal, generally all classes in Here I think dx clearly wins, moreover the perf loss is only during compilation. |
thus, if you end up whitelisting most folders in |
I'm also aware of this tracking issue - and it was on my list for the future to fix, because I think it's a bug. Specifically, if we remove a private service (because it's unused), then we could/should be smart enough to remove its I think we should keep just |
False assumption: just add an interface on one of them, and autoconfig might add it as eg an event subscriber. This will happen in the dev cycle of many. The current behavior is just accurate to me, no bug. |
@nicolas-grekas you're correct - if we don't track a class and then someone adds an autoconfigurable interface, the container wouldn't rebuild. I still think we should keep only |
Let's try, +1 :) |
This PR was merged into the master branch. Discussion ---------- Tweak configuration for app.yaml symfony/symfony-standard#1070 Commits ------- 7581f44 tweaked configuration for app.yaml
symfony/symfony-standard#1070