minor #33194 [Console] Fix incomplete output mock (derrabus)

chalasr · chalasr · commit 15cd8cfd433b · 2019-08-16T04:37:03.000+02:00
This PR was merged into the 4.3 branch. Discussion ---------- [Console] Fix incomplete output mock | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | N/A | License | MIT | Doc PR | N/A Backport from #33153. Merging this up should fix the broken tests on 4.4 and master. Commits ------- 6ecbcf6 [Console] Fix incomplete output mock.
diff --git a/src/Symfony/Component/Console/Tests/Helper/DumperTest.php b/src/Symfony/Component/Console/Tests/Helper/DumperTest.php
@@ -37,7 +37,10 @@ public static function tearDownAfterClass(): void
      */
     public function testInvoke($variable)
     {
-        $dumper = new Dumper($this->getMockBuilder(OutputInterface::class)->getMock());
+        $output = $this->getMockBuilder(OutputInterface::class)->getMock();
+        $output->method('isDecorated')->willReturn(false);
+
+        $dumper = new Dumper($output);
 
         $this->assertDumpMatchesFormat($dumper($variable), $variable);
     }

Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,10 @@ public static function tearDownAfterClass(): void`
`37`	`37`	`*/`
`38`	`38`	`public function testInvoke($variable)`
`39`	`39`	`{`
`40`		`- $dumper = new Dumper($this->getMockBuilder(OutputInterface::class)->getMock());`
	`40`	`+ $output = $this->getMockBuilder(OutputInterface::class)->getMock();`
	`41`	`+ $output->method('isDecorated')->willReturn(false);`
	`42`	`+`
	`43`	`+ $dumper = new Dumper($output);`
`41`	`44`
`42`	`45`	`$this->assertDumpMatchesFormat($dumper($variable), $variable);`
`43`	`46`	`}`