bug #33575 [WebProfilerBundle] Fix time panel legend buttons (fancyweb)

fabpot · fabpot · commit 1a9c6338f30e · 2019-09-15T10:39:57.000+02:00
This PR was merged into the 4.3 branch. Discussion ---------- [WebProfilerBundle] Fix time panel legend buttons | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | #33536 | License | MIT | Doc PR | - It fixes the buttons multiple generations and the toggle behavior as well. Commits ------- 7f4c8d3 [WebProfilerBundle] Fix time panel legend buttons
diff --git a/src/Symfony/Bundle/WebProfilerBundle/Resources/views/Collector/time.js b/src/Symfony/Bundle/WebProfilerBundle/Resources/views/Collector/time.js
@@ -220,7 +220,9 @@ class Legend {
         this.toggle = this.toggle.bind(this);
         this.createCategory = this.createCategory.bind(this);
 
-        this.categories = Array.from(Object.keys(classnames)).map(this.createCategory);
+        this.categories = [];
+
+        Object.keys(classnames).forEach(this.createCategory);
     }
 
     add(category) {
@@ -238,6 +240,8 @@ class Legend {
 
         this.element.appendChild(element);
 
+        this.categories.push(element);
+
         return element;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -220,7 +220,9 @@ class Legend {`
`220`	`220`	`this.toggle = this.toggle.bind(this);`
`221`	`221`	`this.createCategory = this.createCategory.bind(this);`
`222`	`222`
`223`		`- this.categories = Array.from(Object.keys(classnames)).map(this.createCategory);`
	`223`	`+ this.categories = [];`
	`224`	`+`
	`225`	`+ Object.keys(classnames).forEach(this.createCategory);`
`224`	`226`	`}`
`225`	`227`
`226`	`228`	`add(category) {`
`@@ -238,6 +240,8 @@ class Legend {`
`238`	`240`
`239`	`241`	`this.element.appendChild(element);`
`240`	`242`
	`243`	`+ this.categories.push(element);`
	`244`	`+`
`241`	`245`	`return element;`
`242`	`246`	`}`
`243`	`247`