Improve performance

GuilhemN · GuilhemN · commit 1aa47980f6a7 · 2016-03-15T17:31:51.000+01:00
diff --git a/src/Symfony/Component/DependencyInjection/Dumper/PhpDumper.php b/src/Symfony/Component/DependencyInjection/Dumper/PhpDumper.php
@@ -58,7 +58,8 @@ class PhpDumper extends Dumper
     private $targetDirRegex;
     private $targetDirMaxMatches;
     private $docStar;
-    private $existingNames = array();
+    private $serviceIdToMethodNameMap = array();
+    private $usedMethodNames = array();
 
     /**
      * @var \Symfony\Component\DependencyInjection\LazyProxy\PhpDumper\DumperInterface
@@ -1350,19 +1351,20 @@ private function getServiceCall($id, Reference $reference = null)
      */
     private function camelize($id)
     {
-        if (isset($this->existingNames[$id])) {
-            return $this->existingNames[$id];
+        if (isset($this->serviceIdToMethodNameMap[$id])) {
+            return $this->serviceIdToMethodNameMap[$id];
         }
 
         $name = Container::camelize($id);
         $uniqueName = $name = preg_replace('/[^a-zA-Z0-9_\x7f-\xff]/', '', $name);
-        $prefix = 1;
+        $suffix = 1;
 
-        while (in_array($uniqueName, $this->existingNames)) {
-            ++$prefix;
-            $uniqueName = $name.$prefix;
+        while (isset($this->usedMethodNames[$uniqueName])) {
+            ++$suffix;
+            $uniqueName = $name.$suffix;
         }
-        $this->existingNames[$id] = $uniqueName;
+        $this->serviceIdToMethodNameMap[$id] = $uniqueName;
+        $this->usedMethodNames[$uniqueName] = true;
 
         return $uniqueName;
     }
