minor #40766 [Notifier] [Bridge] Remove hidden dependency on HttpFoundation (Nyholm)

nicolas-grekas · nicolas-grekas · commit 1e4241175f72 · 2021-04-11T14:44:57.000+02:00
This PR was merged into the 5.3-dev branch. Discussion ---------- [Notifier] [Bridge] Remove hidden dependency on HttpFoundation | Q | A | ------------- | --- | Branch? | 5.x | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR | We dont need HttpFoundation to give us this constant. HttpFoundation is also missing from composer.json Commits ------- d37f158 [Notifier][Bridge] Remove hidden dependency on HttpFoundation
diff --git a/src/Symfony/Component/Notifier/Bridge/Gitter/GitterTransport.php b/src/Symfony/Component/Notifier/Bridge/Gitter/GitterTransport.php
@@ -11,7 +11,6 @@
 
 namespace Symfony\Component\Notifier\Bridge\Gitter;
 
-use Symfony\Component\HttpFoundation\Response;
 use Symfony\Component\Notifier\Exception\TransportException;
 use Symfony\Component\Notifier\Exception\UnsupportedMessageTypeException;
 use Symfony\Component\Notifier\Message\ChatMessage;
@@ -69,7 +68,7 @@ protected function doSend(MessageInterface $message): SentMessage
 
         $result = $response->toArray(false);
 
-        if (Response::HTTP_OK !== $response->getStatusCode()) {
+        if (200 !== $response->getStatusCode()) {
             throw new TransportException(sprintf('Unable to post the Gitter message: "%s".', $result['error']), $response);
         }
 
diff --git a/src/Symfony/Component/Notifier/Bridge/LightSms/LightSmsTransport.php b/src/Symfony/Component/Notifier/Bridge/LightSms/LightSmsTransport.php
@@ -11,7 +11,6 @@
 
 namespace Symfony\Component\Notifier\Bridge\LightSms;
 
-use Symfony\Component\HttpFoundation\Response;
 use Symfony\Component\Notifier\Exception\TransportException;
 use Symfony\Component\Notifier\Exception\UnsupportedMessageTypeException;
 use Symfony\Component\Notifier\Message\MessageInterface;
@@ -118,7 +117,7 @@ protected function doSend(MessageInterface $message): SentMessage
             ]
         );
 
-        if (Response::HTTP_OK !== $response->getStatusCode()) {
+        if (200 !== $response->getStatusCode()) {
             throw new TransportException('Unable to send the SMS.', $response);
         }
 

Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,6 @@`
`11`	`11`
`12`	`12`	`namespace Symfony\Component\Notifier\Bridge\LightSms;`
`13`	`13`
`14`		`-use Symfony\Component\HttpFoundation\Response;`
`15`	`14`	`use Symfony\Component\Notifier\Exception\TransportException;`
`16`	`15`	`use Symfony\Component\Notifier\Exception\UnsupportedMessageTypeException;`
`17`	`16`	`use Symfony\Component\Notifier\Message\MessageInterface;`
`@@ -118,7 +117,7 @@ protected function doSend(MessageInterface $message): SentMessage`
`118`	`117`	`]`
`119`	`118`	`);`
`120`	`119`
`121`		`- if (Response::HTTP_OK !== $response->getStatusCode()) {`
	`120`	`+ if (200 !== $response->getStatusCode()) {`
`122`	`121`	`throw new TransportException('Unable to send the SMS.', $response);`
`123`	`122`	`}`
`124`	`123`