[Notifier] [Bridge] Remove hidden dependency on HttpFoundation #40766
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jderusse
approved these changes
Apr 11, 2021
|
Thank you @Nyholm. |
fabpot
added a commit
that referenced
this pull request
Jun 3, 2021
…tion for SmsBiurasTransport (fre5h) This PR was merged into the 5.3 branch. Discussion ---------- [Notifier] [Bridge] Remove hidden dependency on HttpFoundation for SmsBiurasTransport | Q | A | ------------- | --- | Branch? | 5.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | License | MIT [SmsBiurasTransport](https://github.com/symfony/symfony/blob/5.3/src/Symfony/Component/Notifier/Bridge/SmsBiuras/SmsBiurasTransport.php#L93) has a hidden dependency on HttpFoundation. Similar to this pull request #40766 but one more class to be fixed Commits ------- c8d3f3e Remove hidden dependency on HttpFoundation for SmsBiurasTransport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We dont need HttpFoundation to give us this constant. HttpFoundation is also missing from composer.json