fix constructor argument type declaration

xabbuh · xabbuh · commit 201af4f31d2c · 2019-12-13T09:10:41.000+01:00
diff --git a/src/Symfony/Component/Lock/Factory.php b/src/Symfony/Component/Lock/Factory.php
@@ -28,7 +28,7 @@ class Factory implements LoggerAwareInterface
 
     private $store;
 
-    public function __construct(StoreInterface $store)
+    public function __construct(PersistingStoreInterface $store)
     {
         $this->store = $store;
 
diff --git a/src/Symfony/Component/Lock/Tests/LockFactoryTest.php b/src/Symfony/Component/Lock/Tests/LockFactoryTest.php
@@ -15,6 +15,7 @@
 use Psr\Log\LoggerInterface;
 use Symfony\Component\Lock\LockFactory;
 use Symfony\Component\Lock\LockInterface;
+use Symfony\Component\Lock\PersistingStoreInterface;
 use Symfony\Component\Lock\StoreInterface;
 
 /**
@@ -23,6 +24,21 @@
 class LockFactoryTest extends TestCase
 {
     public function testCreateLock()
+    {
+        $store = $this->getMockBuilder(PersistingStoreInterface::class)->getMock();
+        $logger = $this->getMockBuilder(LoggerInterface::class)->getMock();
+        $factory = new LockFactory($store);
+        $factory->setLogger($logger);
+
+        $lock = $factory->createLock('foo');
+
+        $this->assertInstanceOf(LockInterface::class, $lock);
+    }
+
+    /**
+     * @group legacy
+     */
+    public function testCreateLockWithLegacyStoreImplementation()
     {
         $store = $this->getMockBuilder(StoreInterface::class)->getMock();
         $logger = $this->getMockBuilder(LoggerInterface::class)->getMock();

Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,7 @@ class Factory implements LoggerAwareInterface`
`28`	`28`
`29`	`29`	`private $store;`
`30`	`30`
`31`		`- public function __construct(StoreInterface $store)`
	`31`	`+ public function __construct(PersistingStoreInterface $store)`
`32`	`32`	`{`
`33`	`33`	`$this->store = $store;`
`34`	`34`