Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit 218f290

Browse files
committed
feature #30584 [Intl] Add compile binary (ro0NL)
This PR was merged into the 3.4 branch. Discussion ---------- [Intl] Add compile binary | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no-ish | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #... <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> Compile the Intl data by invoking a single command, and make it work out-of-the-box. (Split from #28831) ```bash $ src/Symfony/Component/Intl/Resources/bin/compile ``` run in repository root because of https://github.com/symfony/symfony/blob/b7e798ef745a09ca2e76fba4afad0a04fcbd9195/src/Symfony/Component/Intl/Data/Generator/LocaleDataGenerator.php#L141 3.4 is ok, 4.2 is not because of #28833 but new locales are introduced in https://github.com/symfony/symfony/pull/28977/files#diff-f52da32e1ee6b93598814090d0749aa6R1 So as long as 3.4 is supported, but branches above add filters etc. during generation we're risking this discrepancy. I suggest after merge in upper branches to re-run `compile` (potential for automating, but run if needed :)) Commits ------- 426b92f [Intl] Add compile binary
2 parents 89f2a47 + 426b92f commit 218f290

File tree

1 file changed

+12
-0
lines changed
  • src/Symfony/Component/Intl/Resources/bin

1 file changed

+12
-0
lines changed
Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
#!/usr/bin/env bash
2+
3+
if [[ $1 == force || ! $(docker ps -a | grep symfony-intl) ]]; then
4+
docker rm -f symfony-intl
5+
docker create --name symfony-intl -it -v /tmp:/tmp -v $(pwd):/app -w /app jakzal/php-intl:7.2-63.1 bash
6+
docker start symfony-intl
7+
docker exec symfony-intl bash -xc "apt-get update && apt-get -y install build-essential"
8+
else
9+
docker start symfony-intl
10+
fi;
11+
12+
docker exec -u $(id -u):$(id -g) symfony-intl php src/Symfony/Component/Intl/Resources/bin/update-data.php

0 commit comments

Comments
 (0)