feature #16994 [Form] Deprecate the "choices_as_values" option of ChoiceType (nicolas-grekas)

nicolas-grekas · nicolas-grekas · commit 2a991210640d · 2015-12-18T09:56:50.000+01:00
This PR was merged into the 3.1-dev branch. Discussion ---------- [Form] Deprecate the "choices_as_values" option of ChoiceType | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Commits ------- 9aa5507 [Form] Deprecate the "choices_as_values" option of ChoiceType
diff --git a/src/Symfony/Component/Form/CHANGELOG.md b/src/Symfony/Component/Form/CHANGELOG.md
@@ -1,6 +1,11 @@
 CHANGELOG
 =========
 
+3.1.0
+-----
+
+ * deprecated the "choices_as_values" option of ChoiceType
+
 3.0.0
 -----
 
diff --git a/src/Symfony/Component/Form/Extension/Core/Type/ChoiceType.php b/src/Symfony/Component/Form/Extension/Core/Type/ChoiceType.php
@@ -264,8 +264,7 @@ public function configureOptions(OptionsResolver $resolver)
                 throw new \RuntimeException('The "choices_as_values" option should not be used. Remove it and flip the contents of the "choices" option instead.');
             }
 
-            // To be uncommented in 3.1
-            //@trigger_error('The "choices_as_values" option is deprecated since version 3.1 and will be removed in 4.0. You should not use it anymore.', E_USER_DEPRECATED);
+            @trigger_error('The "choices_as_values" option is deprecated since version 3.1 and will be removed in 4.0. You should not use it anymore.', E_USER_DEPRECATED);
 
             return true;
         };
@@ -302,7 +301,7 @@ public function configureOptions(OptionsResolver $resolver)
             'multiple' => false,
             'expanded' => false,
             'choices' => array(),
-            'choices_as_values' => null, // to be deprecated in 3.1
+            'choices_as_values' => null, // deprecated since 3.1
             'choice_loader' => null,
             'choice_label' => null,
             'choice_name' => null,
