Skip target with state="needs-translation" in XLIFF files

nicolas-grekas · nicolas-grekas · commit 3406cd3c0528 · 2024-01-04T14:45:43.000+01:00
diff --git a/src/Symfony/Component/Translation/Loader/XliffFileLoader.php b/src/Symfony/Component/Translation/Loader/XliffFileLoader.php
@@ -111,6 +111,10 @@ private function extractXliff1(\DOMDocument $dom, MessageCatalogue $catalogue, s
                     continue;
                 }
 
+                if (isset($translation->target) && 'needs-translation' === (string) $translation->target->attributes()['state']) {
+                    continue;
+                }
+
                 $source = isset($attributes['resname']) && $attributes['resname'] ? $attributes['resname'] : $translation->source;
                 // If the xlf file has another encoding specified, try to convert it because
                 // simple_xml will always return utf-8 encoded values
diff --git a/src/Symfony/Component/Translation/Tests/fixtures/resources.xlf b/src/Symfony/Component/Translation/Tests/fixtures/resources.xlf
@@ -18,6 +18,10 @@
         <target>with</target>
         <note>note</note>
       </trans-unit>
+      <trans-unit id="5">
+        <source>skipped</source>
+        <target state="needs-translation">skipped</target>
+      </trans-unit>
     </body>
   </file>
 </xliff>
diff --git a/src/Symfony/Component/Validator/Resources/translations/validators.zh_TW.xlf b/src/Symfony/Component/Validator/Resources/translations/validators.zh_TW.xlf
@@ -430,14 +430,6 @@
                 <source>The extension of the file is invalid ({{ extension }}). Allowed extensions are {{ extensions }}.</source>
                 <target>無效的副檔名 ({{ extension }}). 允許的副檔名有 {{ extensions }}.</target>
             </trans-unit>
-            <trans-unit id="111">
-                <source>The detected character encoding is invalid ({{ detected }}). Allowed encodings are {{ encodings }}.</source>
-                <target state="needs-review-translation">偵測到的字元編碼無效 ({{ detected }})。允許的編碼為 {{ encodings }}。</target>
-            </trans-unit>
-            <trans-unit id="112">
-                <source>This is not a valid MAC address.</source>
-                <target state="needs-review-translation">這不是一個有效的MAC地址。</target>
-            </trans-unit>
         </body>
     </file>
 </xliff>
