minor #44837 [Security] make login link handler tests time sensitive (xabbuh)

nicolas-grekas · nicolas-grekas · commit 3b3f87fce569 · 2021-12-29T11:04:27.000+01:00
This PR was merged into the 5.3 branch. Discussion ---------- [Security] make login link handler tests time sensitive | Q | A | ------------- | --- | Branch? | 5.3 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | https://ci.appveyor.com/project/fabpot/symfony/builds/42030777#L735 | License | MIT | Doc PR | Commits ------- 40f2f4d make login link handler tests time sensitive
diff --git a/src/Symfony/Component/Security/Http/LoginLink/LoginLinkHandler.php b/src/Symfony/Component/Security/Http/LoginLink/LoginLinkHandler.php
@@ -46,9 +46,9 @@ public function __construct(UrlGeneratorInterface $urlGenerator, UserProviderInt
 
     public function createLoginLink(UserInterface $user, Request $request = null): LoginLinkDetails
     {
-        $expiresAt = new \DateTimeImmutable(sprintf('+%d seconds', $this->options['lifetime']));
+        $expires = time() + $this->options['lifetime'];
+        $expiresAt = new \DateTimeImmutable('@'.$expires);
 
-        $expires = $expiresAt->format('U');
         $parameters = [
             // @deprecated since Symfony 5.3, change to $user->getUserIdentifier() in 6.0
             'user' => method_exists($user, 'getUserIdentifier') ? $user->getUserIdentifier() : $user->getUsername(),
diff --git a/src/Symfony/Component/Security/Http/Tests/LoginLink/LoginLinkHandlerTest.php b/src/Symfony/Component/Security/Http/Tests/LoginLink/LoginLinkHandlerTest.php
@@ -52,6 +52,7 @@ protected function setUp(): void
     }
 
     /**
+     * @group time-sensitive
      * @dataProvider provideCreateLoginLinkData
      */
     public function testCreateLoginLink($user, array $extraProperties, Request $request = null)

Original file line number	Diff line number	Diff line change
`@@ -52,6 +52,7 @@ protected function setUp(): void`
`52`	`52`	`}`
`53`	`53`
`54`	`54`	`/**`
	`55`	`+ * @group time-sensitive`
`55`	`56`	`* @dataProvider provideCreateLoginLinkData`
`56`	`57`	`*/`
`57`	`58`	`public function testCreateLoginLink($user, array $extraProperties, Request $request = null)`