bug #28377 fix fopen flags (SpacePossum)

fabpot · fabpot · commit 40fff43ea998 · 2018-09-07T05:20:27.000+02:00
This PR was merged into the 2.8 branch. Discussion ---------- fix fopen flags | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | none | License | MIT | Doc PR | none  Commits ------- 6d155ed fix fopen calls
diff --git a/src/Symfony/Component/Process/Process.php b/src/Symfony/Component/Process/Process.php
@@ -1413,8 +1413,8 @@ private function resetProcessData()
         $this->exitcode = null;
         $this->fallbackStatus = array();
         $this->processInformation = null;
-        $this->stdout = fopen('php://temp/maxmemory:'.(1024 * 1024), 'wb+');
-        $this->stderr = fopen('php://temp/maxmemory:'.(1024 * 1024), 'wb+');
+        $this->stdout = fopen('php://temp/maxmemory:'.(1024 * 1024), 'w+b');
+        $this->stderr = fopen('php://temp/maxmemory:'.(1024 * 1024), 'w+b');
         $this->process = null;
         $this->latestSignal = null;
         $this->status = self::STATUS_READY;
diff --git a/src/Symfony/Component/Translation/Dumper/CsvFileDumper.php b/src/Symfony/Component/Translation/Dumper/CsvFileDumper.php
@@ -38,7 +38,7 @@ public function format(MessageCatalogue $messages, $domain = 'messages')
      */
     public function formatCatalogue(MessageCatalogue $messages, $domain, array $options = array())
     {
-        $handle = fopen('php://memory', 'rb+');
+        $handle = fopen('php://memory', 'r+b');
 
         foreach ($messages->all($domain) as $source => $target) {
             fputcsv($handle, array($source, $target), $this->delimiter, $this->enclosure);

Original file line number	Diff line number	Diff line change
`@@ -38,7 +38,7 @@ public function format(MessageCatalogue $messages, $domain = 'messages')`
`38`	`38`	`*/`
`39`	`39`	`public function formatCatalogue(MessageCatalogue $messages, $domain, array $options = array())`
`40`	`40`	`{`
`41`		`- $handle = fopen('php://memory', 'rb+');`
	`41`	`+ $handle = fopen('php://memory', 'r+b');`
`42`	`42`
`43`	`43`	`foreach ($messages->all($domain) as $source => $target) {`
`44`	`44`	`fputcsv($handle, array($source, $target), $this->delimiter, $this->enclosure);`