fix fopen flags #28377
Merged
fix fopen flags #28377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
SpacePossum
commented
Sep 6, 2018
| Q | A |
|---|---|
| Branch? | 2.7 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | none |
| License | MIT |
| Doc PR | none |
SpacePossum
commented
Sep 6, 2018
| @@ -1413,8 +1413,8 @@ private function resetProcessData() | |||
| $this->exitcode = null; | |||
| $this->fallbackStatus = array(); | |||
| $this->processInformation = null; | |||
| $this->stdout = fopen('php://temp/maxmemory:'.(1024 * 1024), 'wb+'); | |||
There was a problem hiding this comment.
wb+ is not valid
SpacePossum
commented
Sep 6, 2018
| @@ -28,7 +28,7 @@ class CsvFileDumper extends FileDumper | |||
| */ | |||
| public function format(MessageCatalogue $messages, $domain = 'messages') | |||
| { | |||
| $handle = fopen('php://memory', 'rb+'); | |||
There was a problem hiding this comment.
rb+ is not valid
|
Hello, can you rebase+retarget on 2.8 please, and also keep only the fixed modes? |
c81b923 to
ae59908
Compare
|
sure thing @nicolas-grekas 👍 |
nicolas-grekas
approved these changes
Sep 6, 2018
fabpot
approved these changes
Sep 7, 2018
|
Thank you @SpacePossum. |
fabpot
added a commit
that referenced
this pull request
Sep 7, 2018
This PR was merged into the 2.8 branch. Discussion ---------- fix fopen flags | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | none | License | MIT | Doc PR | none <!-- Fixes the flags/mode used with `fopen` --> Commits ------- 6d155ed fix fopen calls
This was referenced Sep 30, 2018
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.