feature #14196 Tweaked some console command styles (javiereguiluz)

fabpot · fabpot · commit 418d0121bc7d · 2015-04-03T14:18:07.000+02:00
This PR was squashed before being merged into the 2.7 branch (closes #14196). Discussion ---------- Tweaked some console command styles | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #14174 | License | MIT | Doc PR | - As discussed, after updating the first console commands to the new style guide, we were going to introduce the needed tweaks. This PR is the first one with those tweaks. ### Tables Headers now are displayed in the usual green color used frequently by Symfony commands: ![table_header](https://cloud.githubusercontent.com/assets/73419/6980286/a126e8cc-d9ef-11e4-8d1e-9a5be21564eb.png) ### Command tiles and section titles I see these titles in a beautiful blue color ... but lots of people use color schemes which make them almost unreadable. Now they use the yellow color frequently used by Symfony commands: ![command_section_titles](https://cloud.githubusercontent.com/assets/73419/6980292/b499627c-d9ef-11e4-9940-e134ee0eb02f.png) ### Listings Elements in a listing no longer add an extra blank line. See #14174 for the rationale. Commits ------- dcf1801 Tweaked some console command styles
diff --git a/src/Symfony/Component/Console/Style/SymfonyStyle.php b/src/Symfony/Component/Console/Style/SymfonyStyle.php
@@ -97,15 +97,15 @@ public function block($messages, $type = null, $style = null, $prefix = ' ', $pa
      */
     public function title($message)
     {
-        $this->writeln(sprintf("\n<fg=blue>%s</fg=blue>\n<fg=blue>%s</fg=blue>\n", $message, str_repeat('=', strlen($message))));
+        $this->writeln(sprintf("\n<comment>%s</>\n<comment>%s</>\n", $message, str_repeat('=', strlen($message))));
     }
 
     /**
      * {@inheritdoc}
      */
     public function section($message)
     {
-        $this->writeln(sprintf("<fg=blue>%s</fg=blue>\n<fg=blue>%s</fg=blue>\n", $message, str_repeat('-', strlen($message))));
+        $this->writeln(sprintf("<comment>%s</>\n<comment>%s</>\n", $message, str_repeat('-', strlen($message))));
     }
 
     /**
@@ -119,7 +119,7 @@ public function listing(array $elements)
             $elements
         );
 
-        $this->writeln(implode("\n\n", $elements)."\n");
+        $this->writeln(implode("\n", $elements)."\n");
     }
 
     /**
@@ -183,6 +183,8 @@ public function caution($message)
      */
     public function table(array $headers, array $rows)
     {
+        $headers = array_map(function ($value) { return sprintf('<info>%s</>', $value); }, $headers);
+
         $table = new Table($this);
         $table->setHeaders($headers);
         $table->setRows($rows);

Original file line number	Diff line number	Diff line change
`@@ -97,15 +97,15 @@ public function block($messages, $type = null, $style = null, $prefix = ' ', $pa`
`97`	`97`	`*/`
`98`	`98`	`public function title($message)`
`99`	`99`	`{`
`100`		`- $this->writeln(sprintf("\n<fg=blue>%s</fg=blue>\n<fg=blue>%s</fg=blue>\n", $message, str_repeat('=', strlen($message))));`
	`100`	`+ $this->writeln(sprintf("\n<comment>%s</>\n<comment>%s</>\n", $message, str_repeat('=', strlen($message))));`
`101`	`101`	`}`
`102`	`102`
`103`	`103`	`/**`
`104`	`104`	`* {@inheritdoc}`
`105`	`105`	`*/`
`106`	`106`	`public function section($message)`
`107`	`107`	`{`
`108`		`- $this->writeln(sprintf("<fg=blue>%s</fg=blue>\n<fg=blue>%s</fg=blue>\n", $message, str_repeat('-', strlen($message))));`
	`108`	`+ $this->writeln(sprintf("<comment>%s</>\n<comment>%s</>\n", $message, str_repeat('-', strlen($message))));`
`109`	`109`	`}`
`110`	`110`
`111`	`111`	`/**`
`@@ -119,7 +119,7 @@ public function listing(array $elements)`
`119`	`119`	`$elements`
`120`	`120`	`);`
`121`	`121`
`122`		`- $this->writeln(implode("\n\n", $elements)."\n");`
	`122`	`+ $this->writeln(implode("\n", $elements)."\n");`
`123`	`123`	`}`
`124`	`124`
`125`	`125`	`/**`
`@@ -183,6 +183,8 @@ public function caution($message)`
`183`	`183`	`*/`
`184`	`184`	`public function table(array $headers, array $rows)`
`185`	`185`	`{`
	`186`	`+ $headers = array_map(function ($value) { return sprintf('<info>%s</>', $value); }, $headers);`
	`187`	`+`
`186`	`188`	`$table = new Table($this);`
`187`	`189`	`$table->setHeaders($headers);`
`188`	`190`	`$table->setRows($rows);`