Tweaked some console command styles #14196
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
Nice job Javier! |
|
👍 |
|
Thank you @javiereguiluz. |
fabpot
added a commit
that referenced
this pull request
Apr 3, 2015
This PR was squashed before being merged into the 2.7 branch (closes #14196). Discussion ---------- Tweaked some console command styles | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #14174 | License | MIT | Doc PR | - As discussed, after updating the first console commands to the new style guide, we were going to introduce the needed tweaks. This PR is the first one with those tweaks. ### Tables Headers now are displayed in the usual green color used frequently by Symfony commands:  ### Command tiles and section titles I see these titles in a beautiful blue color ... but lots of people use color schemes which make them almost unreadable. Now they use the yellow color frequently used by Symfony commands:  ### Listings Elements in a listing no longer add an extra blank line. See #14174 for the rationale. Commits ------- dcf1801 Tweaked some console command styles
| @@ -183,6 +183,8 @@ public function caution($message) | |||
| */ | |||
| public function table(array $headers, array $rows) | |||
| { | |||
| $headers = array_map(function ($value) { return sprintf('<info>%s</>', $value); }, $headers); | |||
There was a problem hiding this comment.
Just out of interest: what's the advantage of </>? I'm seeing it more and more these days and I'm not sure why. Probably, there is a reason for it.
There was a problem hiding this comment.
I'm the one who introduced that, so, mainly to avoid too much noise.
There was a problem hiding this comment.
I personally use it because the code looks more much concise and clear to me. Since this is just markup and not "real code", I want it to mess my code as less as possible. That's why using </info> looks very repetitive to me. When using custom styles (e.g. <fg=blue>) duplicating it in the closing tag loks awfully boring to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed, after updating the first console commands to the new style guide, we were going to introduce the needed tweaks. This PR is the first one with those tweaks.
Tables
Headers now are displayed in the usual green color used frequently by Symfony commands:
Command tiles and section titles
I see these titles in a beautiful blue color ... but lots of people use color schemes which make them almost unreadable. Now they use the yellow color frequently used by Symfony commands:
Listings
Elements in a listing no longer add an extra blank line. See #14174 for the rationale.