Add named constructor on JsonResponse

tyx · tyx · commit 4a14137ff56a · 2016-08-05T22:43:03.000+02:00
To make easier construction with raw json
diff --git a/src/Symfony/Component/HttpFoundation/JsonResponse.php b/src/Symfony/Component/HttpFoundation/JsonResponse.php
@@ -58,6 +58,14 @@ public static function create($data = null, $status = 200, $headers = array())
         return new static($data, $status, $headers);
     }
 
+    /**
+     * Make easier the creation of JsonResponse from raw json
+     */
+    public static function fromJsonString($data = null, $status = 200, $headers = array())
+    {
+        return new static($data, $status, $headers, true);
+    }
+
     /**
      * Sets the JSONP callback.
      *
diff --git a/src/Symfony/Component/HttpFoundation/Tests/JsonResponseTest.php b/src/Symfony/Component/HttpFoundation/Tests/JsonResponseTest.php
@@ -198,6 +198,12 @@ public function testSetEncodingOptions()
         $this->assertEquals('{"0":{"0":1,"1":2,"2":3}}', $response->getContent());
     }
 
+    public function testItAcceptsJsonAsString()
+    {
+        $response = JsonResponse::fromJsonString('{"foo":"bar"}');
+        $this->assertSame('{"foo":"bar"}', $response->getContent());
+    }
+
     /**
      * @expectedException \InvalidArgumentException
      */

Original file line number	Diff line number	Diff line change
`@@ -58,6 +58,14 @@ public static function create($data = null, $status = 200, $headers = array())`
`58`	`58`	`return new static($data, $status, $headers);`
`59`	`59`	`}`
`60`	`60`
	`61`	`+ /**`
	`62`	`+ * Make easier the creation of JsonResponse from raw json`
	`63`	`+ */`
	`64`	`+ public static function fromJsonString($data = null, $status = 200, $headers = array())`
	`65`	`+ {`
	`66`	`+ return new static($data, $status, $headers, true);`
	`67`	`+ }`
	`68`	`+`
`61`	`69`	`/**`
`62`	`70`	`* Sets the JSONP callback.`
`63`	`71`	`*`