bug #26947 [Messenger] Support nested configuration on adapters (sroze)

sroze · sroze · commit 507989db878e · 2018-04-16T23:30:47.000+01:00
This PR was merged into the 4.1-dev branch. Discussion ---------- [Messenger] Support nested configuration on adapters | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #26936 | License | MIT | Doc PR | ø The configuration of options did not support "in-depth" configuration. This adds it. Commits ------- 177cea0 Support nested configuration on adapters
diff --git a/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php b/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php
@@ -1030,9 +1030,8 @@ function ($a) {
                                     ->scalarNode('dsn')->end()
                                     ->arrayNode('options')
                                         ->normalizeKeys(false)
-                                            ->useAttributeAsKey('name')
-                                            ->defaultValue(array())
-                                            ->prototype('variable')
+                                        ->defaultValue(array())
+                                        ->prototype('variable')
                                         ->end()
                                     ->end()
                                 ->end()
diff --git a/src/Symfony/Bundle/FrameworkBundle/Resources/config/schema/symfony-1.0.xsd b/src/Symfony/Bundle/FrameworkBundle/Resources/config/schema/symfony-1.0.xsd
@@ -371,17 +371,12 @@
 
     <xsd:complexType name="messenger_adapter">
         <xsd:sequence>
-            <xsd:element name="option" type="messenger_adapter_option" minOccurs="0" maxOccurs="unbounded" />
+            <xsd:element name="options" type="metadata" minOccurs="0" maxOccurs="unbounded" />
         </xsd:sequence>
         <xsd:attribute name="name" type="xsd:string" />
         <xsd:attribute name="dsn" type="xsd:string" />
     </xsd:complexType>
 
-    <xsd:complexType name="messenger_adapter_option">
-        <xsd:attribute name="name" type="xsd:string" />
-        <xsd:attribute name="value" type="xsd:string" />
-    </xsd:complexType>
-
     <xsd:complexType name="messenger_middleware">
         <xsd:sequence>
             <xsd:element name="validation" type="messenger_validation" minOccurs="0" maxOccurs="1" />
diff --git a/src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/Fixtures/php/messenger_adapter.php b/src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/Fixtures/php/messenger_adapter.php
@@ -6,7 +6,7 @@
             'default' => 'amqp://localhost/%2f/messages',
             'customised' => array(
                 'dsn' => 'amqp://localhost/%2f/messages?exchange_name=exchange_name',
-                'options' => array('queue_name' => 'Queue'),
+                'options' => array('queue' => array('name' => 'Queue')),
             ),
         ),
     ),
diff --git a/src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/Fixtures/xml/messenger_adapter.xml b/src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/Fixtures/xml/messenger_adapter.xml
@@ -9,7 +9,11 @@
         <framework:messenger>
             <framework:adapter name="default" dsn="amqp://localhost/%2f/messages" />
             <framework:adapter name="customised" dsn="amqp://localhost/%2f/messages?exchange_name=exchange_name">
-                <framework:option name="queue_name" value="Queue" />
+                <framework:options>
+                    <framework:queue>
+                        <framework:name>Queue</framework:name>
+                    </framework:queue>
+                </framework:options>
             </framework:adapter>
         </framework:messenger>
     </framework:config>
diff --git a/src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/Fixtures/yml/messenger_adapter.yml b/src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/Fixtures/yml/messenger_adapter.yml
@@ -5,4 +5,5 @@ framework:
             customised:
                 dsn: 'amqp://localhost/%2f/messages?exchange_name=exchange_name'
                 options:
-                    queue_name: Queue
+                    queue:
+                        name: Queue
diff --git a/src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/FrameworkExtensionTest.php b/src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/FrameworkExtensionTest.php
@@ -557,7 +557,7 @@ public function testMessengerAdapter()
         $this->assertEquals(array(new Reference('messenger.adapter_factory'), 'createSender'), $senderFactory);
         $this->assertCount(2, $senderArguments);
         $this->assertSame('amqp://localhost/%2f/messages?exchange_name=exchange_name', $senderArguments[0]);
-        $this->assertSame(array('queue_name' => 'Queue'), $senderArguments[1]);
+        $this->assertSame(array('queue' => array('name' => 'Queue')), $senderArguments[1]);
 
         $this->assertTrue($container->hasDefinition('messenger.receiver.customised'));
         $receiverFactory = $container->getDefinition('messenger.receiver.customised')->getFactory();
@@ -566,7 +566,7 @@ public function testMessengerAdapter()
         $this->assertEquals(array(new Reference('messenger.adapter_factory'), 'createReceiver'), $receiverFactory);
         $this->assertCount(2, $receiverArguments);
         $this->assertSame('amqp://localhost/%2f/messages?exchange_name=exchange_name', $receiverArguments[0]);
-        $this->assertSame(array('queue_name' => 'Queue'), $receiverArguments[1]);
+        $this->assertSame(array('queue' => array('name' => 'Queue')), $receiverArguments[1]);
     }
 
     public function testTranslator()
