Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Messenger] Adapter options has goofy syntax #26936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
davidbarratt opened this issue Apr 15, 2018 · 2 comments
Closed

[Messenger] Adapter options has goofy syntax #26936

davidbarratt opened this issue Apr 15, 2018 · 2 comments
Labels
Bug Messenger Status: Needs Review

Comments

@davidbarratt
Copy link

Q A
Bug report? yes
Feature request? no
BC Break report? no
RFC? no
Symfony version 4.1

If you want to set the name of the exchange, outside of the DSN, you have to use a syntax like this:

framework:
    messenger:
        adapters:
          rsvp:
            dsn: "%env(MESSENGER_ADAPTER_DSN)%"
            options:
              -
                name: exchange
                value:
                  name: rsvp

Shouldn't this just be something like this?

framework:
    messenger:
        adapters:
          rsvp:
            dsn: "%env(MESSENGER_ADAPTER_DSN)%"
            options:
              exchange:
                name: rsvp
@sroze
Copy link
Contributor

sroze commented Apr 15, 2018

Fair point. I'd 👍such syntax over the first one, definitely.

@sroze sroze mentioned this issue Apr 16, 2018
Merged
sroze added a commit that referenced this issue Apr 16, 2018
@sroze
bug #26947 [Messenger] Support nested configuration on adapters (sroze)
507989d 
This PR was merged into the 4.1-dev branch.

Discussion
----------

[Messenger] Support nested configuration on adapters

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #26936
| License       | MIT
| Doc PR        | ø

The configuration of options did not support "in-depth" configuration. This adds it.

Commits
-------

177cea0 Support nested configuration on adapters
@sroze
Copy link
Contributor

sroze commented Apr 16, 2018

Fixed by #26947.

@sroze sroze closed this as completed Apr 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Messenger Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@sroze @davidbarratt @xabbuh @carsonbot