Throw exception when render a field which was already rendered

yceruto · yceruto · commit 51d1ed5bdbb5 · 2019-05-29T14:34:22.000-04:00
diff --git a/src/Symfony/Component/Form/CHANGELOG.md b/src/Symfony/Component/Form/CHANGELOG.md
@@ -5,6 +5,7 @@ CHANGELOG
 -----
 
  * removed the `ChoiceLoaderInterface` implementation in `CountryType`, `LanguageType`, `LocaleType` and `CurrencyType`
+ * calling to `FormRenderer::searchAndRenderBlock()` method for fields which were already rendered throw a `BadMethodCallException`
 
 4.3.0
 -----
diff --git a/src/Symfony/Component/Form/FormRenderer.php b/src/Symfony/Component/Form/FormRenderer.php
@@ -133,9 +133,7 @@ public function searchAndRenderBlock(FormView $view, $blockNameSuffix, array $va
 
         if ($renderOnlyOnce && $view->isRendered()) {
             // This is not allowed, because it would result in rendering same IDs multiple times, which is not valid.
-            @trigger_error(sprintf('You are calling "form_%s" for field "%s" which has already been rendered before, trying to render fields which were already rendered is deprecated since Symfony 4.2 and will throw an exception in 5.0.', $blockNameSuffix, $view->vars['name']), E_USER_DEPRECATED);
-            // throw new BadMethodCallException(sprintf('Field "%s" has already been rendered. Save result of previous  render call to variable and output that instead.', $view->vars['name']));
-            return '';
+            throw new BadMethodCallException(sprintf('Field "%s" has already been rendered, save the result of previous render call to a variable and output that instead.', $view->vars['name']));
         }
 
         // The cache key for storing the variables and types
diff --git a/src/Symfony/Component/Form/Tests/FormRendererTest.php b/src/Symfony/Component/Form/Tests/FormRendererTest.php
@@ -12,6 +12,8 @@
 namespace Symfony\Component\Form\Tests;
 
 use PHPUnit\Framework\TestCase;
+use Symfony\Component\Form\FormRenderer;
+use Symfony\Component\Form\FormView;
 
 class FormRendererTest extends TestCase
 {
@@ -26,4 +28,19 @@ public function testHumanize()
         $this->assertEquals('Is active', $renderer->humanize('is_active'));
         $this->assertEquals('Is active', $renderer->humanize('isActive'));
     }
+
+    /**
+     * @expectedException \Symfony\Component\Form\Exception\BadMethodCallException
+     * @expectedExceptionMessage Field "foo" has already been rendered, save the result of previous render call to a variable and output that instead.
+     */
+    public function testRenderARenderedField()
+    {
+        $formView = new FormView();
+        $formView->vars['name'] = 'foo';
+        $formView->setRendered();
+
+        $engine = $this->getMockBuilder('Symfony\Component\Form\FormRendererEngineInterface')->getMock();
+        $renderer = new FormRenderer($engine);
+        $renderer->searchAndRenderBlock($formView, 'row');
+    }
 }

Original file line number	Diff line number	Diff line change
`@@ -133,9 +133,7 @@ public function searchAndRenderBlock(FormView $view, $blockNameSuffix, array $va`
`133`	`133`
`134`	`134`	`if ($renderOnlyOnce && $view->isRendered()) {`
`135`	`135`	`// This is not allowed, because it would result in rendering same IDs multiple times, which is not valid.`
`136`		`- @trigger_error(sprintf('You are calling "form_%s" for field "%s" which has already been rendered before, trying to render fields which were already rendered is deprecated since Symfony 4.2 and will throw an exception in 5.0.', $blockNameSuffix, $view->vars['name']), E_USER_DEPRECATED);`
`137`		`- // throw new BadMethodCallException(sprintf('Field "%s" has already been rendered. Save result of previous render call to variable and output that instead.', $view->vars['name']));`
`138`		`- return '';`
	`136`	`+ throw new BadMethodCallException(sprintf('Field "%s" has already been rendered, save the result of previous render call to a variable and output that instead.', $view->vars['name']));`
`139`	`137`	`}`
`140`	`138`
`141`	`139`	`// The cache key for storing the variables and types`