[DI] fix perf issue with lazy autowire error messages

nicolas-grekas · nicolas-grekas · commit 56b244a348a0 · 2019-07-24T16:20:30.000+02:00
diff --git a/src/Symfony/Component/DependencyInjection/Compiler/AutowirePass.php b/src/Symfony/Component/DependencyInjection/Compiler/AutowirePass.php
@@ -375,14 +375,20 @@ private function set(string $type, string $id)
 
     private function createTypeNotFoundMessageCallback(TypedReference $reference, $label)
     {
-        $container = new ContainerBuilder($this->container->getParameterBag());
-        $container->setAliases($this->container->getAliases());
-        $container->setDefinitions($this->container->getDefinitions());
-        $container->setResourceTracking(false);
-        $currentId = $this->currentId;
-
-        return function () use ($container, $reference, $label, $currentId) {
-            return $this->createTypeNotFoundMessage($container, $reference, $label, $currentId);
+        $state = [
+            $this->container->getParameterBag(),
+            $this->container->getAliases(),
+            $this->container->getDefinitions(),
+            $this->currentId,
+        ];
+
+        return function () use ($reference, $label, $state) {
+            $container = new ContainerBuilder($state[0]);
+            $container->setAliases($state[1]);
+            $container->setDefinitions($state[2]);
+            $container->setResourceTracking(false);
+
+            return $this->createTypeNotFoundMessage($container, $reference, $label, $state[3]);
         };
     }
 
