minor #30564 [HttpClient] Fix HttpOptions::setAuthBearer() (dunglas)

nicolas-grekas · nicolas-grekas · commit 59e63805a311 · 2019-03-14T12:10:39.000+01:00
This PR was merged into the 4.3-dev branch. Discussion ---------- [HttpClient] Fix HttpOptions::setAuthBearer() | Q | A | ------------- | --- | Branch? | master  | Bug fix? | yes | New feature? | no  | BC breaks? | no  | Deprecations? | no  | Tests pass? | yes  | Fixed tickets | n/a  | License | MIT | Doc PR | n/a I messed up the option name while rebasing... Commits ------- 7308e5a [HttpClient] Fix HttpOptions::setAuthBearer()
diff --git a/src/Symfony/Component/HttpClient/HttpOptions.php b/src/Symfony/Component/HttpClient/HttpOptions.php
@@ -49,7 +49,7 @@ public function setAuthBasic(string $user, string $password = '')
      */
     public function setAuthBearer(string $token)
     {
-        $this->options['bearer'] = $token;
+        $this->options['auth_bearer'] = $token;
 
         return $this;
     }
diff --git a/src/Symfony/Component/HttpClient/Tests/HttpOptionsTest.php b/src/Symfony/Component/HttpClient/Tests/HttpOptionsTest.php
@@ -19,7 +19,7 @@
  */
 class HttpOptionsTest extends TestCase
 {
-    public function provideSetAuth()
+    public function provideSetAuthBasic()
     {
         yield ['user:password', 'user', 'password'];
         yield ['user:password', 'user:password'];
@@ -28,10 +28,15 @@ public function provideSetAuth()
     }
 
     /**
-     * @dataProvider provideSetAuth
+     * @dataProvider provideSetAuthBasic
      */
-    public function testSetAuth(string $expected, string $user, string $password = '')
+    public function testSetAuthBasic(string $expected, string $user, string $password = '')
     {
         $this->assertSame($expected, (new HttpOptions())->setAuthBasic($user, $password)->toArray()['auth_basic']);
     }
+
+    public function testSetAuthBearer()
+    {
+        $this->assertSame('foobar', (new HttpOptions())->setAuthBearer('foobar')->toArray()['auth_bearer']);
+    }
 }

Original file line number	Diff line number	Diff line change
`@@ -49,7 +49,7 @@ public function setAuthBasic(string $user, string $password = '')`
`49`	`49`	`*/`
`50`	`50`	`public function setAuthBearer(string $token)`
`51`	`51`	`{`
`52`		`- $this->options['bearer'] = $token;`
	`52`	`+ $this->options['auth_bearer'] = $token;`
`53`	`53`
`54`	`54`	`return $this;`
`55`	`55`	`}`
Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,7 @@`
`19`	`19`	`*/`
`20`	`20`	`class HttpOptionsTest extends TestCase`
`21`	`21`	`{`
`22`		`- public function provideSetAuth()`
	`22`	`+ public function provideSetAuthBasic()`
`23`	`23`	`{`
`24`	`24`	`yield ['user:password', 'user', 'password'];`
`25`	`25`	`yield ['user:password', 'user:password'];`
`@@ -28,10 +28,15 @@ public function provideSetAuth()`
`28`	`28`	`}`
`29`	`29`
`30`	`30`	`/**`
`31`		`- * @dataProvider provideSetAuth`
	`31`	`+ * @dataProvider provideSetAuthBasic`
`32`	`32`	`*/`
`33`		`- public function testSetAuth(string $expected, string $user, string $password = '')`
	`33`	`+ public function testSetAuthBasic(string $expected, string $user, string $password = '')`
`34`	`34`	`{`
`35`	`35`	`$this->assertSame($expected, (new HttpOptions())->setAuthBasic($user, $password)->toArray()['auth_basic']);`
`36`	`36`	`}`
	`37`	`+`
	`38`	`+ public function testSetAuthBearer()`
	`39`	`+ {`
	`40`	`+ $this->assertSame('foobar', (new HttpOptions())->setAuthBearer('foobar')->toArray()['auth_bearer']);`
	`41`	`+ }`
`37`	`42`	`}`